LIVE-1429 leftovers — the verifier still could not see the write
The Broader Goal at the End of the Previous PR
PR #1441 stopped _reconcile_daemon_jobs from overwriting a corroborated done with permission_denied. LIVE-1429 closed. The goalpost was: job status should match GitHub ground truth for gh-write jobs.
Strategic Shifts in This PR
#1441 was necessary and not sufficient. The review and merge dispatches for #1441 itself proved it:
job-1c68bfd4posted an APPROVED review assynlynk-synlynk-qa[bot]and still storedgh_write_verified=false/permission_denied.job-be622768squash-merged #1441 and storedgh_write_expect=pr_open/gh_write_verified=unknown.job-be18ebe7(the original LIVE-1429 job) storedgh_write_target=pr:1414for an issue, while the PR was #1415.
Those are verifier contract bugs, not classifier overwrites. Filed as #1442 plus two fingerprints found while checking whether #1441 actually closed the class.
What This PR Shipped
- #1442. When
expect=pr_openandgh pr view Ncannot resolve a pull request, search PRslinked:issue-Ncreated aftersince(optional author match). - Author login. GraphQL
loginissynlynk-synlynk-qa; stored expect_author issynlynk-synlynk-qa[bot]. Compare after stripping a[bot]suffix. - Naive
sinceis local wall time.daemon_jobs.started_athas no offset. Treating it as UTC made a 03:54Z review look older than a 09:19 IST start. - Expect order. Check merge before "opens a PR". Prompts that say
Do not open a new PRafter a merge instruction no longer classify aspr_open.
Brainstorm Visuals Used
None.
What This Achieved on the Path to Autonomy
#1441 made a success stay done when corroboration exists. This PR makes corroboration actually fire for the three gh-write shapes we just ran (open a new PR for an issue, post a review, merge a PR). Without it, synlynk jobs still trains operators to ignore the board.
Strategic Note: The Goal at the End of This PR
Job-status truth for gh-write is one cluster: classifier guard (#1441) + target/expect/author/time (#1442 and this PR). Next P0 is still the 24-PR triage (#1435), after this lands.